[gettext] Remove SUBPATH, add iconv linking info#20090
Merged
BillyONeal merged 6 commits intomicrosoft:masterfrom Sep 16, 2021
Merged
[gettext] Remove SUBPATH, add iconv linking info#20090BillyONeal merged 6 commits intomicrosoft:masterfrom
SUBPATH, add iconv linking info#20090BillyONeal merged 6 commits intomicrosoft:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
7 tasks
JackBoosY
added
the
category:port-feature
JackBoosY
reviewed
Sep 10, 2021
JackBoosY
approved these changes
Sep 10, 2021
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@dg0yt can you also remove the |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
@wrobelda I have to revert the related change. The issue is that kf5i18n doesn't use the wrapped |
JackBoosY
approved these changes
Sep 16, 2021
JackBoosY
added
the
info:needs-maintainer-attention
BillyONeal
reviewed
Sep 16, 2021
Member
|
Thanks for the bugfix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
SUBPATHargument tovcpkg_build_make, as discussed in [scripts-audit] Make buildsystem (port) #19753 (CC @JackBoosY)Iconv_LIBRARIEStoIntl_LIBRARIESin Intl wrapper, as discussed in [kf5package] new port #19195 (CC @wrobelda)Reverts the kf5i18n patching for the gettext -> iconv dependency which is now handled in gettext ([gettext] Remove(kf5i18n doesn't useSUBPATH, add iconv linking info #20090 (comment)).FindIntl.cmake.)Which triplets are supported/not supported? Have you updated the CI baseline?
all, no
Tested locally in x64-mingw-static cross build.
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?yes